Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: several bugs #4500

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: several bugs #4500

merged 1 commit into from
Jan 24, 2025

Conversation

romange
Copy link
Collaborator

@romange romange commented Jan 24, 2025

  1. Fixes Special Redis commands can cause the Dragonfly service to crash #4466 (we did not check validity of the scan cursor) We fix it by quietly returning "end of scan" result, i.e. no error are returned.
  2. Add 34b1048274c8e50a0cc587a3ed9c383a82bb78c5 sha to the lua_undeclared_keys_shas list.
  3. Pull helio that fixes bugs with WaitQueue and IdleTasks: romange/helio@2ab4412

@romange
fix: several bugs
d1fac0f 
1. Fixes #4466 (we did not check validity of the scan cursor)
   We fix it by quietly returning "end of scan" result, i.e. no error are returned.
2. Add 34b1048274c8e50a0cc587a3ed9c383a82bb78c5 sha to the lua_undeclared_keys_shas list.
3. Pull helio that fixes bugs with WaitQueue and IdleTasks: romange/helio@2ab4412
@romange romange requested a review from BorysTheDev January 24, 2025 08:58
@kostasrim
Copy link
Contributor

@romange There are two alpine builds missing from the required checks. There are 4 here but actually we have 6. See https://github.com/dragonflydb/dragonfly/actions/runs/12946405416/job/36110868326

We need to modify the filter in the settings of the project (I don't have access to this)

@kostasrim
Copy link
Contributor

@romange There are two alpine builds missing from the required checks. There are 4 here but actually we have 6. See https://github.com/dragonflydb/dragonfly/actions/runs/12946405416/job/36110868326

We need to modify the filter in the settings of the project (I don't have access to this)

ignore me, the UI has changed and once a test succeeds it does not show up. Everything is fine.

@romange romange merged commit 23af41c into main Jan 24, 2025
10 checks passed
@romange romange deleted the Pr1 branch January 24, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostasrim kostasrim kostasrim left review comments

@BorysTheDev BorysTheDev BorysTheDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special Redis commands can cause the Dragonfly service to crash
3 participants
@romange @kostasrim @BorysTheDev